Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace event emitter lib #681

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Replace event emitter lib #681

merged 3 commits into from
Jun 13, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented May 2, 2023

events hasn't had an update since 2021, this PR replaces it with eventemitter3

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

🦋 Changeset detected

Latest commit: 1e5b786

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from davidzhao May 2, 2023 14:07
@lukasIO
Copy link
Contributor Author

lukasIO commented May 2, 2023

just realised this would alter the types of Room | Participant | Track

@lukasIO lukasIO closed this May 2, 2023
@lukasIO
Copy link
Contributor Author

lukasIO commented Jun 8, 2023

I'll reopen this, as the change is definitely desirable, we'll just have to decide whether to wait for it until the next major or the next minor release.

@lukasIO lukasIO reopened this Jun 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 82.24 KB (-1.94% 🔽)
dist/livekit-client.umd.js 86.02 KB (-1.12% 🔽)

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukasIO lukasIO merged commit 8a0c94b into main Jun 13, 2023
@lukasIO lukasIO deleted the lukas/listen-closing branch June 13, 2023 08:53
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants