Support passing room to useIsEncrypted #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7135493 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
renekliment
force-pushed
the
useIsEncrypted-room-option
branch
from
4d86640
to
6dc2a2b
Compare
renekliment
force-pushed
the
useIsEncrypted-room-option
branch
from
6dc2a2b
to
5be8d72
Compare
|
this makes sense, thanks for your contribution! |
lukasIO
approved these changes
May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am aware this is alpha, so I am not sure how much support this gets.
I would find it useful if the hook could also get the room passed directly as other hooks so it can be used in a place where
Roomis manually created, where the room context is not available. 🙏I was not sure whether the hook should only get
optionswhere bothparticipantandroomcould be. I can rewrite it to that if that makes more sense. 🙏