Fix deadlock in appsrc #116
Conversation
|
This calls UnBind manually on the sample provider when the LocalSampleTrack fails, since it seems that Pion/the Go SDK do not. Is this the right approach, or should the fix be made in Pion or the SDK? |
|
would be good to fix the root cause here, either in Pion or SDK |
The SDK/Pion do end up calling Unbind, when we unpublish the whole track. However, here, the pipeline ends up entirely stuck when the Go SDK stops pulling samples for one of the variants because of the read error I generate for testing. This means the the GST EOF message is never received, the other variants never finish processing, and the track never gets unpublished. I think calling Unbind manually is the right fix here, as it prevents the whole GST pipeline from being stuck by discarding buffers on the failed variant. |
This is the v1.0.0 release of the ingress service. This release stabilizes the API and adds support for the WHIP protocol ## Changelog ### Added - WHIP support (#97) - Expose heath and availability on the WHIP HTTP server (#109) - Add support for optimally bypassing transcoding when ingesting WHIP (#111) - Set the source track information in the ingress state (#121) ### Fixed - Validate IngressInfo and populate missing fields with defaults (#90) - Fix deadlock in appsrc (#116) - Update synchronizer and use Jitter Buffer (#118)
No description provided.