Validate IngressInfo and populate missing fields with defaults #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
reviewed
Apr 7, 2023
pkg/media/presets.go
Outdated
| "github.com/livekit/ingress/pkg/errors" | ||
| "github.com/livekit/protocol/livekit" | ||
| ) | ||
|
|
||
| const ( | ||
| // reference parameters used to compute bitrate | ||
| refBitrate = 3_000_000 |
There was a problem hiding this comment.
I think you mentioned bumping this up a bit. wdyt?
There was a problem hiding this comment.
The most pressing is to increase the bitrate of the medium and low layers I think. We do this here by taking the power to 0.75 of the pixel area ratio. This was chosen to double the bitrate of the low layer (1/4 width and 1/4 height), compared to scaling the bitrate linearly.
We should probably reassess the 3Mbps value for 1080p content as well, but I'd want more time and more content to test to pick a value.
davidzhao
approved these changes
Apr 7, 2023
Merged
biglittlebigben
added a commit
that referenced
this pull request
Jun 26, 2023
This is the v1.0.0 release of the ingress service. This release stabilizes the API and adds support for the WHIP protocol ## Changelog ### Added - WHIP support (#97) - Expose heath and availability on the WHIP HTTP server (#109) - Add support for optimally bypassing transcoding when ingesting WHIP (#111) - Set the source track information in the ingress state (#121) ### Fixed - Validate IngressInfo and populate missing fields with defaults (#90) - Fix deadlock in appsrc (#116) - Update synchronizer and use Jitter Buffer (#118)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also run until tests on pull requests.