Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: allow rooms to be created automatically on connect #1

Closed
davidzhao opened this issue Jan 25, 2021 · 1 comment
Closed

feature: allow rooms to be created automatically on connect #1

davidzhao opened this issue Jan 25, 2021 · 1 comment

Comments

@davidzhao
Copy link
Member

No description provided.

@davidzhao
Copy link
Member Author

feature added in f004aa2

boks1971 added a commit that referenced this issue Mar 15, 2023
@boks1971
Fix connection quality in constrained up stream
ad71a40 
A few things
1. Have to use expected layer in upstream distance to desired. Using
min(published, expected) means if expected is higher than published, it was not caught as a missed layer.
2. Forgot to remove layer transition update in one place. It was still constrained to screen share.
This caused quality to not pick up after constraint is released.
3. Switching to max layer cannot be marked on max published. Same as point #1 above. Otherwise,
dynacast would kick in and turn off highest layer.
@boks1971 boks1971 mentioned this issue Mar 15, 2023
Merged
boks1971 added a commit that referenced this issue Mar 15, 2023
@boks1971
Fix connection quality in constrained up stream (#1521)
582adda 
A few things
1. Have to use expected layer in upstream distance to desired. Using
min(published, expected) means if expected is higher than published, it was not caught as a missed layer.
2. Forgot to remove layer transition update in one place. It was still constrained to screen share.
This caused quality to not pick up after constraint is released.
3. Switching to max layer cannot be marked on max published. Same as point #1 above. Otherwise,
dynacast would kick in and turn off highest layer.
@MichaelYang1995 MichaelYang1995 mentioned this issue May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidzhao