Fix connection quality in constrained up stream #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few things 1. Have to use expected layer in upstream distance to desired. Using min(published, expected) means if expected is higher than published, it was not caught as a missed layer. 2. Forgot to remove layer transition update in one place. It was still constrained to screen share. This caused quality to not pick up after constraint is released. 3. Switching to max layer cannot be marked on max published. Same as point #1 above. Otherwise, dynacast would kick in and turn off highest layer.
davidzhao
approved these changes
Mar 15, 2023
cnderrauber
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things