Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More time stamp dance. #1712

Merged
merged 1 commit into from
May 16, 2023
Merged

More time stamp dance. #1712

merged 1 commit into from
May 16, 2023

Conversation

boks1971
Copy link
Contributor

Two things

  • Somehow the publisher RTCP sender report time stamp goes back some times. Log it differently. Also, use signed type for logging so that negative is easy to see.
  • On down track, because of silence frame injection on mute, the RTCP sender report time stamp might be ahead of timestamp we will use on unmute. If so, ensure that next timestamp is also not before what was sent in RTCP sender report.

@boks1971
More time stamp dance.
4a35567 
Two things
- Somehow the publisher RTCP sender report time stamp goes back some
  times. Log it differently. Also, use signed type for logging so
  that negative is easy to see.
- On down track, because of silence frame injection on mute, the RTCP
  sender report time stamp might be ahead of timestamp we will use
  on unmute. If so, ensure that next timestamp is also not before
  what was sent in RTCP sender report.
@boks1971 boks1971 merged commit 9395f0b into master May 16, 2023
@boks1971 boks1971 deleted the raja_ts branch May 16, 2023 16:18
hautvfami pushed a commit to Stark-Industries-Ltd/livekit that referenced this pull request Jul 21, 2023
@boks1971 @hautvfami
More time stamp dance. (livekit#1712)
bfff265 
Two things
- Somehow the publisher RTCP sender report time stamp goes back some
  times. Log it differently. Also, use signed type for logging so
  that negative is easy to see.
- On down track, because of silence frame injection on mute, the RTCP
  sender report time stamp might be ahead of timestamp we will use
  on unmute. If so, ensure that next timestamp is also not before
  what was sent in RTCP sender report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulwe paulwe paulwe approved these changes

@davidzhao davidzhao Awaiting requested review from davidzhao

@cnderrauber cnderrauber Awaiting requested review from cnderrauber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boks1971 @paulwe