Drop padding only packets on publisher side. #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulwe
approved these changes
Aug 23, 2023
| @@ -404,42 +408,40 @@ func (b *Buffer) SetRTT(rtt uint32) { | |||
| } | |||
|
|
|||
| func (b *Buffer) calc(pkt []byte, arrivalTime time.Time) { | |||
There was a problem hiding this comment.
Yes, per packet in the upstream direction.
davidzhao
approved these changes
Aug 24, 2023
cnderrauber
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a good time to bring in the extended range implementation in this PR - #1548.
But, for now, just returning extended sequence number from RTPStats Update and storing offsets in a new struct called
RangeMap.RangeMapis used to store a value for certain ranges. It is used as followsIn this implementation (although it is using generics), extended sequence number is calculated (16 bits extended to 32 bits) and a certain number of ranges are maintained (100 in this PR to limit memory). If there is a retransmission/out-of-order arrives, adjustment is retrieved from the cache. For in-order packets, the running value is used for adjustment.
With this change, it is possible to simplify the subscriber side, i. e. can skip checking for padding only packets on subscriber side. But, will do that change in a different PR if this change works fine. Have tested it a bunch using NLC, but it is hard to test all scenarios and needs real world testing.