Introduce DISCONNECTED connection quality.
#2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this state happens when any up stream track does not send any packets in an analysis window when it is expected to send packets. This can be used by participants to know the quality of a potentially disconnected participant. Previously, it took 20 - 30 seconds for the stale timeout to kick in and disconnect the limbo participant which triggered a participant update through which other participants knew about it. Previously, `POOR` quality was also overloaded to denote that the up stream is not sending any packets. With this change, that is a separate indicator, i. e. `DISCONNECTED`.
cnderrauber
approved these changes
Nov 27, 2023
pkg/sfu/connectionquality/scorer.go
Outdated
| @@ -219,7 +220,10 @@ func (q *qualityScorer) Start() { | |||
| func (q *qualityScorer) updateMuteAtLocked(isMuted bool, at time.Time) { | |||
| if isMuted { | |||
| q.mutedAt = at | |||
| q.score = maxScore | |||
| // mting when DISCONNECTED should not push quality to EXCELLENT | |||
paulwe
approved these changes
Nov 27, 2023
davidzhao
reviewed
Nov 28, 2023
| @@ -531,7 +536,11 @@ func scoreToConnectionQuality(score float64) livekit.ConnectionQuality { | |||
| return livekit.ConnectionQuality_GOOD | |||
| } | |||
|
|
|||
| return livekit.ConnectionQuality_POOR | |||
| if score > 20.0 { | |||
There was a problem hiding this comment.
nit: better to use const cMinScore here?
There was a problem hiding this comment.
Was just using numbers there. Will change it. Actually, can use 'cDisconnectedScore' which might be easier to read. Will make constants for others too in a separate PR.
|
hi, when do you plan to release this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this state happens when any up stream track does not send any packets in an analysis window when it is expected to send packets.
This can be used by participants to know the quality of a potentially disconnected participant. Previously, it took 20 - 30 seconds for the stale timeout to kick in and disconnect the limbo participant which triggered a participant update through which other participants knew about it.
Previously,
POORquality was also overloaded to denote that the up stream is not sending any packets. With this change, that is a separate indicator, i. e.DISCONNECTED.For #2048