Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address some TODOs #119

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Address some TODOs #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions handlers/transcode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ func (d *CatalystAPIHandlersCollection) TranscodeSegment() httprouter.Handle {
if err != nil {
errors.WriteHTTPInternalServerError(w, "Error running Transcode process", err)
}

// TODO: Success callback to Studio
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now happens inside the transcode method itself

}
}

Expand Down
1 change: 0 additions & 1 deletion handlers/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ func (d *CatalystAPIHandlersCollection) UploadVOD() httprouter.Handle {
}

func (d *CatalystAPIHandlersCollection) processUploadVOD(streamName, sourceURL, targetURL string) error {
// TODO: remove this logic to force input URLs to mp4/mov format
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're keeping this for now

sourceURL = "mp4:" + sourceURL
if err := d.MistClient.AddStream(streamName, sourceURL); err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion transcode/manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func GenerateAndUploadManifests(sourceManifest m3u8.MediaPlaylist, targetOSURL s
masterPlaylist.Append(
fmt.Sprintf("rendition-%d/rendition.m3u8", i),
&m3u8.MediaPlaylist{
TargetDuration: 10, // TODO: Don't hardcode
TargetDuration: sourceManifest.TargetDuration,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just take it off the source manifest, since we're not forcing a different TargetDuration at this point

},
m3u8.VariantParams{
Name: fmt.Sprintf("%d-%s", i, profile.Name),
Expand Down
1 change: 0 additions & 1 deletion transcode/transcode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ func RunTranscodeProcess(transcodeRequest TranscodeSegmentRequest, streamName st
}

// Iterate through the segment URLs and transcode them
// TODO: Some level of parallelisation once we're happy this works well
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now being tracked under #111 so we can ditch the TODO

for segmentIndex, u := range sourceSegmentURLs {
rc, err := clients.DownloadOSURL(u.URL)
if err != nil {
Expand Down