-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transcoded rendition folder names #159
Update transcoded rendition folder names #159
Conversation
Instead of rendition-* folder names, use the profile name (e.g. 720p, 1080p, etc) as the folder name to make it more user friendly.
83be991
to
39570cf
Compare
76cfda8
to
e3e2825
Compare
Codecov Report
@@ Coverage Diff @@
## emran/fix-remote-b-transcode #159 +/- ##
======================================================================
+ Coverage 42.57075% 42.63840% +0.06765%
======================================================================
Files 24 24
Lines 1696 1698 +2
======================================================================
+ Hits 722 724 +2
Misses 883 883
Partials 91 91
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely
…stream's resolution (#157) * transcode: update profile name for rendition that matches the source stream's resolution Remote B (via access-token) rejects transcode request if a profile with name "source" is used. The "source" keyword is used to define an incoming RTMP push in go-livepeer (server/mediaserver.go) - which triggers a different use-case. Change the profile name to follow the name syntax (e.g. 720p) being used for the other profiles. * transcode: fix transcode test * Update transcoded rendition folder names (#159) * transcode: use nicer names for rendition folders Instead of rendition-* folder names, use the profile name (e.g. 720p, 1080p, etc) as the folder name to make it more user friendly. * transcode: fix failing tests
Instead of rendition-* folder names, use the profile name (e.g. 720p,
1080p, etc) as the folder name to make it more user friendly.