Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confluence addresses + a few minor sidebar positioning fixes #94

Merged
merged 5 commits into from Jan 12, 2022
Merged

Confluence addresses + a few minor sidebar positioning fixes #94

merged 5 commits into from Jan 12, 2022

Conversation

hthillman
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jan 12, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/livepeer/docs/7JawHED6MzBknyv3c3ZvCuZ9VM6j
✅ Preview: https://docs-git-confluence-addresses-livepeer.vercel.app

yondonfu
yondonfu requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes requested.

Also, doing a few additional tests with the new Rinkeby contracts and will confirm here once those are done.

docs/protocol/reference/deployed.md Outdated Show resolved Hide resolved
docs/protocol/reference/deployed.md Outdated Show resolved Hide resolved
docs/protocol/reference/deployed.md Outdated Show resolved Hide resolved
docs/protocol/reference/deployed.md Outdated Show resolved Hide resolved
docs/protocol/reference/deployed.md Outdated Show resolved Hide resolved
docs/protocol/reference/deployed.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 12, 2022 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview January 12, 2022 18:08 Inactive
yondonfu
yondonfu approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

And testing on the new testnet contracts is done so we're good to go.

@hthillman hthillman merged commit 0efa7f7 into main Jan 12, 2022
@hthillman hthillman deleted the confluence-addresses branch January 12, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hthillman @yondonfu