pm: clear senderNonces once their recipientRand has expired #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriediculous
changed the title
|
Looks like this PR currently contains a bunch of commits from other branches. Can we cleanup the commit history so that only the relevant commits for this feature are in the PR? |
|
Since #1495 seems pretty close I'll just wait until that one is rebased and then rebase this one on top as well if that's okay. |
kyriediculous
force-pushed
the
nv/rework-sendermonitor
branch
2 times, most recently
from
32dc739
to
0420149
Compare
kyriediculous
force-pushed
the
nv/clear-sendernonces
branch
from
abb37d7
to
adee003
Compare
kyriediculous
force-pushed
the
nv/rework-sendermonitor
branch
from
e080334
to
5837891
Compare
|
This PR is now a single commit |
kyriediculous
force-pushed
the
nv/rework-sendermonitor
branch
from
cb03516
to
0614c90
Compare
kyriediculous
force-pushed
the
nv/clear-sendernonces
branch
from
adee003
to
9528218
Compare
kyriediculous
force-pushed
the
nv/rework-sendermonitor
branch
from
0614c90
to
dbb1c71
Compare
kyriediculous
force-pushed
the
nv/clear-sendernonces
branch
from
9528218
to
899bba8
Compare
kyriediculous
force-pushed
the
nv/rework-sendermonitor
branch
from
dbb1c71
to
ef33f2b
Compare
kyriediculous
force-pushed
the
nv/clear-sendernonces
branch
from
899bba8
to
7a7c656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Relevant commit abb37d7
This PR creates a watchdog to clear senderNonces from the
recipient.senderNoncesmap.The watchdog will subscribe to new block events from the
TimeManager, each time a new block is seen we'll loop through thesenderNoncesmap and remove therecipientRandif it has expired (is past itsParamExpirationBlockSpecific updates (required)
recipient.senderNoncesmap to take instruct{nonce uint32; expirationBlock *big.Int}clearSenderNoncemethodsenderNoncesCleanupLoop()method that is started on a go routine when callingrecipient.Start()How did you test each of these updates (required)
Added a unit test and ran it
Does this pull request close any open issues?
Fixes #1498
Checklist:
./test.shpass