Add support for H264 profiles #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0sh
requested changes
Jun 22, 2020
|
PS: For some reason the segmenter test case is failing - I guess it's unrelated to my changes because it fails on my local |
j0sh
reviewed
Jun 23, 2020
| {"name": "prof2", "bitrate": 765, "fps": 876, "fpsDen": 12, "width": 456, "height": 987}, | ||
| {"name": "passthru_fps", "bitrate": 890, "width": 789, "height": 654}]}`) | ||
| {"name": "passthru_fps", "bitrate": 890, "width": 789, "height": 654, "profile": "H264ConstrainedHigh"}]}`) |
There was a problem hiding this comment.
Actually it already is mixed case....!!
j0sh
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
LGTM 🚢
Added some back-compat regression tests here https://gist.github.com/j0sh/9d884a19bb92e504092e71fd19d812e5#file-profiles-standalone-sh and https://gist.github.com/j0sh/9d884a19bb92e504092e71fd19d812e5#file-profiles-sh , things seem to work nicely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR adds support for specifying the H264 encoder profile (#1531) by passing it as a field in the VideoProfile related structs.
Specific updates (required)
net.VideoProfilestruct - Serialize/Deserialize to LPMS VideoProfileFullProfiles3field only when the new Profiles field is usedHow did you test each of these updates (required)
Does this pull request close any open issues?
Fixes #1531
Checklist:
./test.shpass