-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save failed mpeg7 signature and segment data for fast verification #2451
Conversation
* cli: add content classification flag, fix capabilities list * docs: update CHANGELOG_PENDING.md * Deliver scene classification results through HTTP for standalone T * Fix changelog * Go fmt * Remove failing test * Fix GPU detection test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, left a few minor comments. +1 for nicely-sized PR.
PS: TestParseAcceptsEitherDatadirCasing
is failing, is it related to changes?
Codecov Report
@@ Coverage Diff @@
## master #2451 +/- ##
===================================================
- Coverage 55.02775% 54.74979% -0.27797%
===================================================
Files 94 95 +1
Lines 19641 19843 +202
===================================================
+ Hits 10808 10864 +56
- Misses 8236 8375 +139
- Partials 597 604 +7
Continue to review full report at Codecov.
|
Allow Orchestrator to set Ticket max face value
Co-authored-by: Thom Shutt <thomshutt@users.noreply.github.com>
fix a dead link
* Include lpms fix; use `ffmpeg.MediaFormatInfo` struct.
* Use LPMS branch `ak/portrait_bug_hunt` * Final LPMS revision
What does this pull request do? Explain your changes. (required)
Related to this issue
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
make
runs successfully./test.sh
pass