Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save failed mpeg7 signature and segment data for fast verification #2451

Closed
wants to merge 31 commits into from

Conversation

oscar-davids
Copy link
Contributor

What does this pull request do? Explain your changes. (required)

Related to this issue

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

oscar-davids and others added 4 commits June 8, 2022 21:34
* cli: add content classification flag, fix capabilities list

* docs: update CHANGELOG_PENDING.md

* Deliver scene classification results through HTTP for standalone T

* Fix changelog

* Go fmt

* Remove failing test

* Fix GPU detection test
Copy link
Contributor

@cyberj0g cyberj0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left a few minor comments. +1 for nicely-sized PR.

PS: TestParseAcceptsEitherDatadirCasing is failing, is it related to changes?

drivers/gssave.go Outdated Show resolved Hide resolved
drivers/gssave.go Outdated Show resolved Hide resolved
drivers/gssave.go Outdated Show resolved Hide resolved
server/broadcast.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2451 (959e580) into master (d360781) will decrease coverage by 0.27796%.
The diff coverage is 20.15209%.

❗ Current head 959e580 differs from pull request most recent head c3d8207. Consider uploading reports for the commit c3d8207 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2451         +/-   ##
===================================================
- Coverage   55.02775%   54.74979%   -0.27797%     
===================================================
  Files             94          95          +1     
  Lines          19641       19843        +202     
===================================================
+ Hits           10808       10864         +56     
- Misses          8236        8375        +139     
- Partials         597         604          +7     
Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 2.30769% <0.00000%> (-0.06856%) ⬇️
cmd/livepeer_cli/livepeer_cli.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_transcoder.go 0.00000% <0.00000%> (ø)
core/livepeernode.go 71.05263% <0.00000%> (-10.76556%) ⬇️
drivers/gssave.go 0.00000% <0.00000%> (ø)
pm/stub.go 56.98113% <0.00000%> (-0.43333%) ⬇️
server/ot_rpc.go 35.75581% <19.23077%> (+9.89910%) ⬆️
server/broadcast.go 77.32975% <33.33333%> (-0.58880%) ⬇️
pm/recipient.go 89.63964% <57.14286%> (-2.45338%) ⬇️
server/handlers.go 53.51598% <73.91304%> (+0.43761%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d360781...c3d8207. Read the comment docs.

@cyberj0g cyberj0g closed this Nov 4, 2022
@hjpotter92 hjpotter92 deleted the oc/saveFVfailcase branch May 2, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants