Inflation change and verifier solver setters. Tweak initial parameters #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yondonfu
commented
Jan 15, 2018
yondonfu
commented
- Setter for inflation change
- Setter for adding solvers to LivepeerVerifier
- Fix LivepeerVerifier tests
- Tweak initial parameters for test deployments
ericxtang
requested changes
Jan 15, 2018
| @@ -55,6 +55,14 @@ contract LivepeerVerifier is Manager, IVerifier { | |||
| verificationCodeHash = _verificationCodeHash; | |||
| } | |||
|
|
|||
| function addSolver(address _solver) external onlyControllerOwner { | |||
| // Must not already be a solver | |||
| require(!isSolver[_solver]); | |||
There was a problem hiding this comment.
We did require(!isSolver[_solvers[i]] && _solvers[i] != address(0)); earlier, should we do address(0) check here too?
|
Small comment, otherwise 🚢 |
ericxtang
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.