Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polling: Use QUORUM according to LIP-16 #380

Merged
merged 1 commit into from May 7, 2020
Merged

polling: Use QUORUM according to LIP-16 #380

merged 1 commit into from May 7, 2020

Conversation

yondonfu
Copy link
Member

@yondonfu yondonfu commented May 7, 2020

Updates PollCreator to use the QUORUM parameter and the default parameter values described in LIP-16.

Fixes #379

@coveralls
Copy link

coveralls commented May 7, 2020 •
edited

Pull Request Test Coverage Report for Build 1343

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1337: 0.0%
Covered Lines: 711
Relevant Lines: 711
💛 - Coveralls

kyriediculous
kyriediculous approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@kyriediculous kyriediculous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yondonfu yondonfu merged commit 00c2294 into streamflow May 7, 2020
@yondonfu yondonfu deleted the yf/lip-16-updates branch May 7, 2020 14:34
@yondonfu yondonfu mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyriediculous kyriediculous kyriediculous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yondonfu @coveralls @kyriediculous