Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

short-cycle: check for presence of media playlists in the master #6

Closed
iameli opened this issue Feb 4, 2021 · 3 comments
Closed

short-cycle: check for presence of media playlists in the master #6

iameli opened this issue Feb 4, 2021 · 3 comments
Assignees
Labels

Comments

@iameli
Copy link
Collaborator

iameli commented Feb 4, 2021

So we had a region down for a number of hours last night - specifically, RTMP ingest worked, but the appropriate playback routes weren't getting added to Consul. So any time playback was attempted, an HTTP 200 was returned along with this playlist:

▶ curl https://region-cdn.livepeer.com/hls/doesnotexist/index.m3u8
#EXTM3U
#EXT-X-ERROR: Stream open failed
#EXT-X-ENDLIST

The short cycle streams apparently did not treat this as an error condition — I assume it was determining that all 0 of the 0 media playlists were returning data correctly or some such. This should throw an error.

@thedeeno
Copy link
Collaborator

thedeeno commented Feb 4, 2021

I'll update the short-cycle to check for this and send a page.

@wohlner
Copy link

wohlner commented Feb 26, 2021

Is this done?

@thedeeno
Copy link
Collaborator

@wohlner yup! Sorry for not closing right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants