-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Create access-control API for signing keys #1275
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
===================================================
+ Coverage 51.06138% 51.36538% +0.30400%
===================================================
Files 66 68 +2
Lines 4334 4431 +97
Branches 786 805 +19
===================================================
+ Hits 2213 2276 +63
- Misses 1842 1865 +23
- Partials 279 290 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Only some smaller nits or questions :)
What does this pull request do? Explain your changes. (required)
Creates a set of API for signing keys, as first milestone toward access control
Specific updates (required)
pem
format for JWT generationsHow did you test each of these updates (required)
yarn test - postman
Does this pull request close any open issues?
Fixes #1284
Screenshots (optional):
Checklist: