-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Add playbackPolicy to assets & streams #1286
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #1286 +/- ##
===================================================
+ Coverage 51.28146% 51.37382% +0.09235%
===================================================
Files 66 66
Lines 4331 4331
Branches 802 802
===================================================
+ Hits 2221 2225 +4
+ Misses 1829 1826 -3
+ Partials 281 280 -1
Continue to review full report at Codecov.
|
…for playback policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sounds great!
…On Thu, 22 Sept 2022, 19:04 gioelecerati, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/api/src/schema/schema.yaml
<#1286 (comment)>:
> @@ -732,6 +738,15 @@ components:
response:
$ref: "#/components/schemas/webhook-response"
+ playback-policy:
So, are you proposing to make something like
"playbackPolicy":{
"type":"signed"
}
for now, where type is the enum and we can expand later? Sounds good to
me, on first iteration when I was putting the signingKey ids inside the
policy it was actually like that. wdyt of the object like this?
—
Reply to this email directly, view it on GitHub
<#1286 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMJ4R2LP7YK63YSVJIFPWLV7TJX3ANCNFSM6AAAAAAQOXCFGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Yeah! Twas just a historical joke hahaha
…On Thu, 22 Sept 2022, 19:02 gioelecerati, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/api/src/schema/schema.yaml
<#1286 (comment)>:
> @@ -964,6 +979,8 @@ components:
readOnly: true
example: https://livepeercdn.com/asset/ea03f37e-f861-4cdd-b495-0e60b6d753ad/index.m3u8
description: URL for HLS playback
+ playbackPolicy:
+ $ref: "#/components/schemas/playback-policy"
wait what am I missing 👀 isn't the $ right there?
—
Reply to this email directly, view it on GitHub
<#1286 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMJ4RYRNMF2OLLNDFASETLV7TJRFANCNFSM6AAAAAAQOXCFGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Turns out GitHub doesn't send the replies in the right conversation lol |
What does this pull request do? Explain your changes. (required)
Add the ability to specify a playback policy to an Asset, making them
public
,signed
orprivate
Comes with #1275
This is also applied to stream
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Fixes #1289
Screenshots (optional):
Checklist: