Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Add playbackPolicy to assets & streams #1286

Merged
merged 6 commits into from
Sep 23, 2022

Conversation

gioelecerati
Copy link
Member

@gioelecerati gioelecerati commented Sep 16, 2022

What does this pull request do? Explain your changes. (required)

Add the ability to specify a playback policy to an Asset, making them public, signed or private
Comes with #1275

This is also applied to stream

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Fixes #1289

Screenshots (optional):

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@gioelecerati gioelecerati requested a review from a team as a code owner September 16, 2022 22:54
@vercel
Copy link

vercel bot commented Sep 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 2:33PM (UTC)

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1286 (adfcec4) into master (d6044aa) will increase coverage by 0.09236%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1286         +/-   ##
===================================================
+ Coverage   51.28146%   51.37382%   +0.09235%     
===================================================
  Files             66          66                 
  Lines           4331        4331                 
  Branches         802         802                 
===================================================
+ Hits            2221        2225          +4     
+ Misses          1829        1826          -3     
+ Partials         281         280          -1     
Impacted Files Coverage Δ
packages/api/src/controllers/asset.ts 54.76190% <100.00000%> (ø)
packages/api/src/webhooks/cannon.ts 49.70760% <0.00000%> (+2.33917%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6044aa...adfcec4. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/controllers/asset.ts 54.76190% <100.00000%> (ø)
packages/api/src/webhooks/cannon.ts 49.70760% <0.00000%> (+2.33917%) ⬆️

@gioelecerati gioelecerati marked this pull request as ready for review September 17, 2022 00:34
@gioelecerati gioelecerati changed the title api: Add playbackPolicy to asset api: Add playbackPolicy to assets & streams Sep 19, 2022
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/api/src/schema/schema.yaml Show resolved Hide resolved
packages/api/src/schema/schema.yaml Show resolved Hide resolved
@victorges
Copy link
Member

victorges commented Sep 23, 2022 via email

@victorges
Copy link
Member

victorges commented Sep 23, 2022 via email

@victorges
Copy link
Member

Turns out GitHub doesn't send the replies in the right conversation lol

@gioelecerati gioelecerati merged commit c6409ce into master Sep 23, 2022
@gioelecerati gioelecerati deleted the gio/api/asset-playback-policy branch September 23, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add playbackPolicy to playable objects (VOD&livestreams)
2 participants