api: Add source field to assets #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is to create a new useful metadata in asset objects which is some object representing
where they come from / how they were created.
The idea for this is to solve an immediate user need for relating their VOD assets with the livestream
sessions of their users. We previously had no official way for that, and had workarounds in our
dashboard that (I didn't even remember but also) we should not have our users depend on
(regex on playback url of the asset).
It also opens room for an API proposed by @yondonfu for supporting automatic import + playback by CID
directly from IPFS (with no need to manually re-store the asset on IPFS).
Specific updates (required)
sourcefield on the asset which could have several types and argssourcefield on every asset creation today.-
Create an asset in the various different ways and make sure source field is set appropriately.
Does this pull request close any open issues?
No. Customer support.
Checklist: