Fetch playback URL for imported asset using source URL #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4 tasks
0xcadams
reviewed
Oct 26, 2022
| limit: 2, | ||
| order: "coalesce((asset.data->'createdAt')::bigint, 0) ASC", | ||
| }); | ||
| if (!assets || assets.length < 1) { |
victorges
approved these changes
Oct 26, 2022
victorges
reviewed
Oct 26, 2022
| @@ -47,7 +47,8 @@ const getAssetPlaybackUrl = async ( | |||
| cid: boolean | |||
| ) => { | |||
| const asset = cid | |||
| ? await db.asset.getByIpfsCid(id) | |||
| ? (await db.asset.getByIpfsCid(id)) ?? | |||
| (await db.asset.getBySourceURL("ipfs://" + id)) | |||
There was a problem hiding this comment.
might wanna add the ar:// here if we add support for that on task runner
yondonfu
force-pushed
the
yf/feat/asset-source-uri-lookup
branch
from
7a69c07
to
9951068
Compare
Missing asset_source_url index in expected result
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
===================================================
+ Coverage 52.12026% 52.21675% +0.09649%
===================================================
Files 68 68
Lines 4457 4466 +9
Branches 831 834 +3
===================================================
+ Hits 2323 2332 +9
Misses 1838 1838
Partials 296 296
Continue to review full report at Codecov.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Supersedes #1367. This PR is also built off of #1365 which introduces a
sourcefield to theAssetentity.This new (and simpler impl in Studio!) approach depends on livepeer/task-runner#76. Instead of allowing a user to specify arbitrary source IDs that can be used to lookup a playback URL via the /playback endpoint, Studio relies on task-runner to handle ipfs:// URLs by importing the asset using a list of trusted IPFS gateways to ensure that the asset imported matches the CID in the ipfs:// URL.
The /playback endpoint will try the following in order for a CID:
storage.ipfs.cidfield of an asset which will be populated if the asset was exported to IPFS by Studiosource.urlfield of an asset which will be populated if the asset was imported from IPFS by Studio. A playback URL will only be returned if the asset'sstatusis set toreadywhich indicates that the asset was actually successfully imported.Specific updates (required)
See commit history.
Updated unit tests.
Does this pull request close any open issues?
Fixes #1362
Screenshots (optional):
Checklist: