Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Storj #1548

Merged
merged 19 commits into from
Dec 20, 2022
Merged

Support Storj #1548

merged 19 commits into from
Dec 20, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Dec 12, 2022

What does this pull request do? Explain your changes. (required)

Add support for /api/transcode endpoint. Read more in the related Technical Design Doc.

Related PRs:

Specific updates (required)

  • Add /api/transcode endpoint in a separate file transcode.ts
  • Add helper functions to operate on object store URLs to helpers.ts
  • Add deleting credentials to task.ts and scheduler.ts

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional):

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Dec 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Dec 20, 2022 at 1:51PM (UTC)

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1548 (b13536c) into master (f5a932a) will increase coverage by 0.39869%.
The diff coverage is 89.47368%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1548         +/-   ##
===================================================
+ Coverage   53.25354%   53.65223%   +0.39869%     
===================================================
  Files             69          70          +1     
  Lines           4595        4641         +46     
  Branches         867         879         +12     
===================================================
+ Hits            2447        2490         +43     
- Misses          1832        1833          +1     
- Partials         316         318          +2     
Impacted Files Coverage Δ
packages/api/src/app-router.ts 51.28205% <ø> (ø)
packages/api/src/controllers/asset.ts 59.02141% <ø> (+0.23353%) ⬆️
packages/api/src/webhooks/cannon.ts 47.36842% <ø> (ø)
packages/api/src/task/scheduler.ts 51.33333% <85.71429%> (+2.41247%) ⬆️
packages/api/src/controllers/helpers.ts 54.28571% <88.88889%> (+3.96724%) ⬆️
packages/api/src/controllers/transcode.ts 90.90909% <90.90909%> (ø)
packages/api/src/controllers/task.ts 28.68852% <92.85714%> (+5.67967%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a932a...b13536c. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/app-router.ts 51.28205% <ø> (ø)
packages/api/src/controllers/asset.ts 59.02141% <ø> (+0.23353%) ⬆️
packages/api/src/webhooks/cannon.ts 47.36842% <ø> (ø)
packages/api/src/task/scheduler.ts 51.33333% <85.71429%> (+2.41247%) ⬆️
packages/api/src/controllers/helpers.ts 54.28571% <88.88889%> (+3.96724%) ⬆️
packages/api/src/controllers/transcode.ts 90.90909% <90.90909%> (ø)
packages/api/src/controllers/task.ts 28.68852% <92.85714%> (+5.67967%) ⬆️


app.post(
"/",
authorizer({}),

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
@leszko leszko marked this pull request as ready for review December 19, 2022 14:25
@leszko leszko requested a review from a team as a code owner December 19, 2022 14:25
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only some minor comments as well.

packages/api/src/controllers/helpers.test.ts Show resolved Hide resolved
packages/api/src/controllers/helpers.test.ts Show resolved Hide resolved
packages/api/src/controllers/helpers.ts Show resolved Hide resolved
packages/api/src/controllers/task.ts Outdated Show resolved Hide resolved
packages/api/src/controllers/transcode.ts Outdated Show resolved Hide resolved
packages/api/src/schema/schema.yaml Outdated Show resolved Hide resolved
packages/api/src/task/scheduler.ts Show resolved Hide resolved
packages/api/src/controllers/transcode.ts Outdated Show resolved Hide resolved
packages/api/src/controllers/transcode.ts Outdated Show resolved Hide resolved
@leszko leszko merged commit 3171e19 into master Dec 20, 2022
@leszko leszko deleted the rafal/storj branch December 20, 2022 14:08
jonoroboto added a commit that referenced this pull request Jan 11, 2023
* Add /api/transcode API (#1548)

* Fix returning S3 credentials from /api/transcode (#1574)

* api: Upgrade tus-node-server from 0.6.0 to 0.9.0 (#1576)

* api: Upgrade tus-node-server from 0.6.0 to 0.9.0

* api: Fix build for new tus lib

* chore(release): publish v0.12.0

* graphql to groq (#1573)

* feat: switch graphql to groq

* chore:

* bug: sanity client refactor

* bug: client import fix

* www: Fix asset details not showing on asset page (#1581)

Only missed a details=1 on the requests.

* bug: portable text disappered fix (#1589)

* Fix all the Next.js warning and errors in the console (#1594)

* Fixed the Stripe initialisation

* Fixed the payment popup which was throwing an error

* Fixed the logo svg width error

* Fixed the error with the mobile menu where auth buttons where rendered differently on server and client

* Fixed the inclusion of two scripts in the Head that were throwing a warnings

* Refactored the Document component to a function component for future work

* Fixed the not-unique key in admin table

* Fixed the non unique key in admin usage table

* Optimised the strip initialisation with useMemo

* Enabling SWC and fixing Admin tables (#1595)

* Fixed the Stripe initialisation

* Fixed the payment popup which was throwing an error

* Fixed the logo svg width error

* Fixed the error with the mobile menu where auth buttons where rendered differently on server and client

* Fixed the inclusion of two scripts in the Head that were throwing a warnings

* Refactored the Document component to a function component for future work

* Fixed the not-unique key in admin table

* Fixed the non unique key in admin usage table

* Enabled SWC for the project
Fixed the Admin table error

* Optimised the strip initialisation with useMemo

* Link resolver (#1556)

* Test bump

* Hotfix: Cleaning up campaign page

* feat: custom link resolver

* chore: target link

* Ran a build, bump

* bump: yarn lock

* bump: removed token from sanity client

Co-authored-by: Jonathan Alford <jono@roboto.studio>

* packages/api: Add version information to prometheus metrics (#1597)

* Pricing page (#1596)

* Test bump

* Hotfix: Cleaning up campaign page

* Added components

* Started to wire components up

* feat: image on social proof

* Cleaned up 2 sections

* Pricing cards nearly there

* Cleaned up pricing card grid sizing and close to finish

* Fixed spacing

* Also cleared all console log errors

Co-authored-by: hrithikroboto <hrithik@roboto.studio>

Co-authored-by: Rafał Leszko <rafal@livepeer.org>
Co-authored-by: Victor Elias <victorgelias@gmail.com>
Co-authored-by: hrithikroboto <114240510+hrithikroboto@users.noreply.github.com>
Co-authored-by: clacla <claudio@livepeer.org>
Co-authored-by: hjpotter92 <hjpotter92@users.noreply.github.com>
Co-authored-by: hrithikroboto <hrithik@roboto.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants