Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Upgrade tus-node-server from 0.6.0 to 0.9.0 #1576

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

Upgrades tus lib in hopes of a fix for the old race condition on uploads.

Specific updates (required)

  • upgrade tus-node-server
  • fix build

How did you test each of these updates (required)

yarn test

Does this pull request close any open issues?

No.

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner January 3, 2023 21:59
@vercel
Copy link

vercel bot commented Jan 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Jan 3, 2023 at 10:07PM (UTC)

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1576 (d25c4b6) into master (3171e19) will increase coverage by 0.01154%.
The diff coverage is 50.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1576         +/-   ##
===================================================
+ Coverage   53.70410%   53.71564%   +0.01154%     
===================================================
  Files             70          70                 
  Lines           4657        4656          -1     
  Branches         884         884                 
===================================================
  Hits            2501        2501                 
+ Misses          1838        1837          -1     
  Partials         318         318                 
Impacted Files Coverage Δ
packages/api/src/controllers/helpers.ts 54.28571% <ø> (ø)
packages/api/src/controllers/asset.ts 59.20245% <50.00000%> (+0.18104%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3171e19...d25c4b6. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/controllers/helpers.ts 54.28571% <ø> (ø)
packages/api/src/controllers/asset.ts 59.20245% <50.00000%> (+0.18104%) ⬆️

Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/api/src/controllers/asset.ts Show resolved Hide resolved
@victorges victorges merged commit 76c81c3 into master Jan 4, 2023
@victorges victorges deleted the vg/chore/upgrade-tus branch January 4, 2023 16:44
jonoroboto added a commit that referenced this pull request Jan 11, 2023
* Add /api/transcode API (#1548)

* Fix returning S3 credentials from /api/transcode (#1574)

* api: Upgrade tus-node-server from 0.6.0 to 0.9.0 (#1576)

* api: Upgrade tus-node-server from 0.6.0 to 0.9.0

* api: Fix build for new tus lib

* chore(release): publish v0.12.0

* graphql to groq (#1573)

* feat: switch graphql to groq

* chore:

* bug: sanity client refactor

* bug: client import fix

* www: Fix asset details not showing on asset page (#1581)

Only missed a details=1 on the requests.

* bug: portable text disappered fix (#1589)

* Fix all the Next.js warning and errors in the console (#1594)

* Fixed the Stripe initialisation

* Fixed the payment popup which was throwing an error

* Fixed the logo svg width error

* Fixed the error with the mobile menu where auth buttons where rendered differently on server and client

* Fixed the inclusion of two scripts in the Head that were throwing a warnings

* Refactored the Document component to a function component for future work

* Fixed the not-unique key in admin table

* Fixed the non unique key in admin usage table

* Optimised the strip initialisation with useMemo

* Enabling SWC and fixing Admin tables (#1595)

* Fixed the Stripe initialisation

* Fixed the payment popup which was throwing an error

* Fixed the logo svg width error

* Fixed the error with the mobile menu where auth buttons where rendered differently on server and client

* Fixed the inclusion of two scripts in the Head that were throwing a warnings

* Refactored the Document component to a function component for future work

* Fixed the not-unique key in admin table

* Fixed the non unique key in admin usage table

* Enabled SWC for the project
Fixed the Admin table error

* Optimised the strip initialisation with useMemo

* Link resolver (#1556)

* Test bump

* Hotfix: Cleaning up campaign page

* feat: custom link resolver

* chore: target link

* Ran a build, bump

* bump: yarn lock

* bump: removed token from sanity client

Co-authored-by: Jonathan Alford <jono@roboto.studio>

* packages/api: Add version information to prometheus metrics (#1597)

* Pricing page (#1596)

* Test bump

* Hotfix: Cleaning up campaign page

* Added components

* Started to wire components up

* feat: image on social proof

* Cleaned up 2 sections

* Pricing cards nearly there

* Cleaned up pricing card grid sizing and close to finish

* Fixed spacing

* Also cleared all console log errors

Co-authored-by: hrithikroboto <hrithik@roboto.studio>

Co-authored-by: Rafał Leszko <rafal@livepeer.org>
Co-authored-by: Victor Elias <victorgelias@gmail.com>
Co-authored-by: hrithikroboto <114240510+hrithikroboto@users.noreply.github.com>
Co-authored-by: clacla <claudio@livepeer.org>
Co-authored-by: hjpotter92 <hjpotter92@users.noreply.github.com>
Co-authored-by: hrithikroboto <hrithik@roboto.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants