Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return live thumbnail URL for everyone #1966

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Return live thumbnail URL for everyone #1966

merged 2 commits into from
Nov 10, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Nov 8, 2023

@victorges does this playback info response look ok to you, the thumbnail source I mean:

{
    "type": "live",
    "meta": {
        "live": 0,
        "source": [
            {
                "hrn": "HLS (TS)",
                "type": "html5/application/vnd.apple.mpegurl",
                "url": "https://livepeercdn.studio/hls/b7caqhzl06ma2iqn/index.m3u8"
            },
            {
                "hrn": "WebRTC (H264)",
                "type": "html5/video/h264",
                "url": "https://livepeercdn.studio/webrtc/b7caqhzl06ma2iqn"
            },
            {
                "hrn": "Thumbnail",
                "type": "image/jpeg",
                "url": "https://storage.lp-playback.studio/raw/juixm77hfsmhyslrxtycnqfmnlfq/catalyst-recordings-com/hls/b7caqhzl06ma2iqn/303c14b0-0b12-4275-8228-dbea616fe82a/source/latest.jpg"
            }
        ]
    }
}

@mjh1 mjh1 requested a review from a team as a code owner November 8, 2023 18:08
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 0:26am

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjh1 WDYT of adding a specification on the hrn [1] with the content type, similar to HLS and WebRTC?
i.e. Thumbnail (JPEG) (then we can also add other formats later if we want)

[1] I always forget what that means, and it's not a general thing. Just found a DM with Jaron where he told me it just means "Human Readable Name". WDYT of adding a comment (description) in our api-schema explaining that it just means that?

@mjh1
Copy link
Contributor Author

mjh1 commented Nov 9, 2023

@victorges I had added this before:

That's what you mean right, I can just rename it to Thumbnail (JPEG)

@mjh1 mjh1 merged commit b5db9dc into master Nov 10, 2023
12 checks passed
@mjh1 mjh1 deleted the mh/open-live-thumb branch November 10, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants