-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
access-control: better logs & dashboard update #1992
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -138,9 +138,14 @@ app.post( | |||
if ( | |||
playbackPolicyType !== "public" && | |||
req.body.pub === req.config.accessControlAdminPubkey && | |||
req.config.accessControlAdminPubkey !== "" && | |||
req.config.accessControlAdminPubkey && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check already contains the above since ""
is falsy
$ node
Welcome to Node.js v21.4.0.
> if ("") {
... console.log("true")
... } else {
... console.log("false")
... }
false
req.body.pub !== "" && | ||
req.body.pub | ||
) { | ||
console.log( | ||
`access-control: gate: allowing admin access for contentId=${content.id} playbackId=${playbackId}, user=${user.id} is admin, pubKey=${req.config.accessControlAdminPubkey} is adminPubKey` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this part is weird: user=${user.id} is admin
Shouldn't you actually log user.admin
here? I don't think there's a guarantee on user
being an admin here (in fact its probably not, since it's the owner of the video, not the caller)
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist