api: Allow patching a stream recordingSpec #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add documentation to stream's and asset's profiles - Reference doc from payloads - Use right type for recordingSpec.profiles - Propagate profiles on upload APIs as well (didn't know they already were configurable there) - Avoid some repetition by cross-referencing payloads
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mjh1
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This was initially to add support for patching a stream's
recordingSpecfield.On the way to that, I spotted a few improvements or fixes that were necessary
in the multiple "profiles" fields we have in the schema. I've included those here.
Specific updates (required)
recordingSpecfield when creating a streamrecordingSpec, copying over the same validation logicHow did you test each of these updates (required)
yarn testDoes this pull request close any open issues?
Implements ENG-2110
Checklist