-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifier -> SwiftUI -> View fundamentals: onAppear(perform:) #608
Comments
It should be more investigated |
I started investigating this and #609 (see 33f5eb4) but ran into an issue: every time an element appears or disappears, both the onAppear and onDisappear callbacks fire. It's not immediately clear to me why, but I suspect it has to do with the notion of element identity not being preserved across view updates (see liveview-native/liveview-native-core#13). |
@AZholtkevych I don't think this is a good ticket for me to work on. If Anil didn't know how to do it then I definitely won't. It involves parts of the architecture I don't know at all. |
I wasn't able to replicate the mentioned issue in a few simple tests, perhaps it shows up with more complex hierarchies. I've opened a PR with @shadowfacts implementation: #970 |
@carson-katri could you please link PR here |
@carson-katri please merge this one |
Doc: https://developer.apple.com/documentation/swiftui/view/onappear(perform:)
The text was updated successfully, but these errors were encountered: