Slot method on view class is not working #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to set a default of a component slot
Signed-off-by: Gertjan Roke <gertjan@2solar.nl>
update master branch
Merge master into feature branch
Signed-off-by: Gertjan Roke <g.a.roke90@gmail.com>
Signed-off-by: Gertjan Roke <g.a.roke90@gmail.com>
GertjanRoke
changed the title
Signed-off-by: Gertjan Roke <g.a.roke90@gmail.com>
|
Well @joshhanley found the fix! Thanks for helping! |
|
The test failure seems to be a GitHub actions issue, connection was refused on the WebDriver for some of the tests in PHP 7.3. The rest of the PHP versions ran fine. Another PR today had the same failure but for PHP 7.2. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was made because the
->slot()method of the view is not working and this came to mind when I was adding a new feature and saw no tests were written for the view methods Livewire adds to the view class.See this PR for more info: #2315