Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slot method on view class is not working #2341

Merged
merged 8 commits into from
Jan 20, 2021
Merged

Slot method on view class is not working #2341

merged 8 commits into from
Jan 20, 2021

Commits on Jan 6, 2021

  1. Added tests for all view macro functions and added new setSlot method… 

    … to set a default of a component slot
    Gertjan Roke committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    58162b0 View commit details
    Browse the repository at this point in the history

  2. Removed dubble underscore

    Gertjan Roke committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    b7dab3b View commit details
    Browse the repository at this point in the history

  3. Added withoutExceptionHandling to see why the test is failing 

    Signed-off-by: Gertjan Roke <gertjan@2solar.nl>
    Gertjan Roke committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    4bf4a5a View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2021

  1. Merge pull request #1 from livewire/master 

    update master branch
    @GertjanRoke
    GertjanRoke committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    ec92858 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from GertjanRoke/master 

    Merge master into feature branch
    @GertjanRoke
    GertjanRoke committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    e20c8af View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. Added tests to test all view functions 

    Signed-off-by: Gertjan Roke <g.a.roke90@gmail.com>
    @GertjanRoke
    GertjanRoke committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    a0966b7 View commit details
    Browse the repository at this point in the history

  2. Removed setSlot method because it should not be in this branch 

    Signed-off-by: Gertjan Roke <g.a.roke90@gmail.com>
    @GertjanRoke
    GertjanRoke committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    4a28437 View commit details
    Browse the repository at this point in the history

  3. Fixed the failing test for the slot method 

    Signed-off-by: Gertjan Roke <g.a.roke90@gmail.com>
    @GertjanRoke
    GertjanRoke committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    efe6927 View commit details
    Browse the repository at this point in the history