Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve-eslint #364

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Improve-eslint #364

merged 4 commits into from
Sep 29, 2023

Conversation

jacob-8
Copy link
Collaborator

@jacob-8 jacob-8 commented Sep 29, 2023

No description provided.

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ld-parts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 2:15pm
living-dictionaries ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2023 2:15pm

@github-actions
Copy link

⚡️Lighthouse report

Results for https://living-dictionaries-e7gl6eymr-livingtongues.vercel.app/ (see detailed report)

Category Score
🔴 Performance 37
🟢 Accessibility 90
🟢 Best practices 100
🟢 SEO 96
🟢 PWA 90

Results for https://living-dictionaries-e7gl6eymr-livingtongues.vercel.app/achi/entries/list (see detailed report)

Category Score
🔴 Performance 33
🟠 Accessibility 88
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 90

Results for https://living-dictionaries-e7gl6eymr-livingtongues.vercel.app/jaRhn6MAZim4Blvr1iEv/entry/yt9ja7ymh9xgba5i (see detailed report)

Category Score
🟠 Performance 60
🟠 Accessibility 89
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 90

Copy link
Collaborator

@Danble Danble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, you extracted the rules of each type of files for lint into different files and changed some rules. Great!

@jacob-8 jacob-8 merged commit 28ddbc1 into main Sep 29, 2023
9 checks passed
@jacob-8 jacob-8 deleted the improve-eslint branch September 29, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants