Skip to content

Commit

Permalink
mount: Fix bug regarding not honored ACL
Browse files Browse the repository at this point in the history
This commit fixes problem with not honored ACLs. Providing
FUSE_CAP_POSIX_ACL capability flag (that was defined in libfuse 3.2.0)
solves the problem for mfsmount3 but not for mfsmount because
FUSE_CAP_POSIX_ACL is defined only in FUSE3 mount_config.h header file.
Removing default_permissions from default mount options would solve the
problem for both mfsmount and mfsmount3 but it would introduce another
one: unprivileged users would be able to elevate their privileges with
setfacl.

Fixes #816

Change-Id: If34502b5ec1b7e2df3eb9fcbbcb35b91a3c3b6f0
  • Loading branch information
Patryk authored and blink69 committed May 28, 2019
1 parent 59988c6 commit e391f55
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/mount/fuse/main.cc
Expand Up @@ -120,6 +120,7 @@ static void mfs_fsinit(void *userdata, struct fuse_conn_info *conn) {
#if FUSE_VERSION >= 30
fuse_conn_info_opts *conn_opts = (fuse_conn_info_opts *)userdata;
fuse_apply_conn_info_opts(conn_opts, conn);
conn->want |= FUSE_CAP_POSIX_ACL;
conn->want &= ~FUSE_CAP_ATOMIC_O_TRUNC;
#endif

Expand Down

0 comments on commit e391f55

Please sign in to comment.