Skip to content

Commit

Permalink
Release 1.3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
Bartosz Kubicki committed Dec 10, 2020
1 parent 8dac859 commit 6760802
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Expand Up @@ -48,4 +48,7 @@

### 1.3.7 ###
* fix constant attachment re-saving
* fix for stale downloaded files in magento root
* fix for stale downloaded files in magento root

### 1.3.8 ###
* fix for not saving attachment
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -9,7 +9,7 @@
"magento/module-ui": "*"
},
"type": "magento2-module",
"version": "1.3.7",
"version": "1.3.8",
"license": [
"MIT"
],
Expand Down
4 changes: 2 additions & 2 deletions etc/fieldset.xml
Expand Up @@ -12,8 +12,8 @@
xsi:noNamespaceSchemaLocation="urn:magento:framework:DataObject/etc/fieldset.xsd">
<scope id="global">
<fieldset id="downloadable_data">
<field name="id">
<aspect name="to_attachment" targetField="attachment_id"/>
<field name="attachment_id">
<aspect name="to_attachment" targetField="id"/>
</field>
<field name="attachment_type">
<aspect name="to_attachment" targetField="attachment_type"/>
Expand Down
2 changes: 1 addition & 1 deletion etc/module.xml
Expand Up @@ -7,7 +7,7 @@
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="LizardMedia_ProductAttachment" setup_version="1.3.7">
<module name="LizardMedia_ProductAttachment" setup_version="1.3.8">
<sequence>
<module name="Magento_Downloadable"/>
<module name="Magento_Catalog"/>
Expand Down

2 comments on commit 6760802

@mmeyran
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I'm still getting that error with 1.3.8 - the module allows duplicate pairs of attachment_id and store_id in the title table, and it does happen. I have put a constraint on these columns directly in database to not break my front anymore, and I'm adding checks to my own code to prevent these extra insertion attempts, but it still happens with store_id 0.
It would be a good idea to add the constraint to the module itself, though.

@bartoszkubicki
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmeyran can you create an issue?

Please sign in to comment.