Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022.3.X Breaks dropdown #84

Closed
regevbr opened this issue Feb 25, 2022 · 16 comments · Fixed by #85
Closed

2022.3.X Breaks dropdown #84

regevbr opened this issue Feb 25, 2022 · 16 comments · Fixed by #85

Comments

@regevbr
Copy link
Contributor

regevbr commented Feb 25, 2022

You are using paper-menu-button and paper-listbox with the assumption Home Assistant will load these elements.

In 2022.3 these elements are no longer part of Home Assistant, so this will no longer work.

see kalkih/mini-media-player#606 for reference

image

@SmarterHomeLife
Copy link

Same for me, breaks the dropdown completely so options aren't clickable even when shown.

@Psytoshgen
Copy link

+1 got this issue about week...

@antro31
Copy link

antro31 commented Mar 6, 2022

+1, same for me

@niclasniedermaier
Copy link

+1

1 similar comment
@compujunk
Copy link

+1

@ljmerza
Copy link
Owner

ljmerza commented Mar 7, 2022

looks like id have to do a bit of work here to get this working again. Unfortunely, I dont have the time right now to look into this but will look into any PRs anyone is able to add.

@regevbr
Copy link
Contributor Author

regevbr commented Mar 8, 2022

looks like id have to do a bit of work here to get this working again. Unfortunely, I dont have the time right now to look into this but will look into any PRs anyone is able to add.

Done, To use the fix until it is released, follow the steps I made here

@habuild
Copy link

habuild commented Mar 10, 2022

Thanks for the fix @regevbr .

Very tiny issue with the fix. The effects list is wider than the card when using it in a horizontal stack with two cards on android Home assistant app(and android chrome browser).

horizontal stack single card active
effects list on horizontal stack 1

horizontal stack double card active
effects list on horizontal stack 2

unstacked card android app
effects list on horizontal stack 3 no stack

horizontal stack desktop chrome browser
effects list on horizontal stack 4 desktop chrome

@regevbr
Copy link
Contributor Author

regevbr commented Mar 10, 2022

Css is out of the scope of my expertise, I will leave it to the maintainer...

@dashdrum
Copy link

looks like id have to do a bit of work here to get this working again. Unfortunely, I dont have the time right now to look into this but will look into any PRs anyone is able to add.

Done, To use the fix until it is released, follow the steps I made here

FYI, this fix works for me when using Chrome, but not in Firefox, where the effects dropdown looks the same as the unfixed example back at the top of the thread.

Thanks for looking into this!

@jsiemek
Copy link

jsiemek commented Mar 16, 2022

For me works OK also in Firefox. Did you clean FF cache?

@regevbr
Copy link
Contributor Author

regevbr commented Mar 16, 2022

@dashdrum I just tried it on my Firefox and it works well. Indeed when you open the menu it can cause an "expansion" of the card (also in Chrome) which I mentioned in the PR and I don't know how to fix, and I will leave that for the maintiner. But unlike the issue, the buttons are still useable and the menu is not stuck in open state. Can you please verify for me that this is indeed the behaviour you are experiencing?

@ljmerza
Copy link
Owner

ljmerza commented Mar 16, 2022

should be fixed in v5.0.0

@bistek22
Copy link

It still does not work
HA v2022.3.5
Light v5.0.0

Cache clear Firefox and Android

Firefox:

Zrzut ekranu 2022-03-16 225801

Apps HA Android:

Screenshot_20220316-225348_Home Assistant

@regevbr
Copy link
Contributor Author

regevbr commented Mar 16, 2022

The first pictures are not related to this issue.
About the app it seems that it was not refreshed yet as it seems like the old ui before the update

@dashdrum
Copy link

@dashdrum I just tried it on my Firefox and it works well. Indeed when you open the menu it can cause an "expansion" of the card (also in Chrome) which I mentioned in the PR and I don't know how to fix, and I will leave that for the maintiner. But unlike the issue, the buttons are still useable and the menu is not stuck in open state. Can you please verify for me that this is indeed the behaviour you are experiencing?

I can confirm that it does indeed work in Firefox. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.