Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #84: 2022.3.X Breaks dropdown #85

Merged
merged 9 commits into from
Mar 16, 2022
Merged

fix #84: 2022.3.X Breaks dropdown #85

merged 9 commits into from
Mar 16, 2022

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented Mar 8, 2022

fix: #84

So according to https://developers.home-assistant.io/blog/2022/02/18/paper-elements/ all paper elements are not supported anymore starting 2022.3 and they recommend using mwc components instead. The current behavior is a complete breakdown of the dropdown menus.

The fix is based on my work on artem-sedykh/mini-climate-card#67

Need to note that this is probably will not work on previous versions of HA and as such, I added a comment in the readme and updated the version to 5 (as this is a breaking change).

@ljmerza if you can take it from here it will be awesome :-)

To use the fix until it is released, follow the steps I made here

@regevbr
Copy link
Contributor Author

regevbr commented Mar 8, 2022

I couldn't find a quick way to exclude certain files from being bundled with webpack, so I changed webpack to roolup. If you prefer, you can undo that, as long as you preserve the behavior.

@regevbr
Copy link
Contributor Author

regevbr commented Mar 13, 2022

@ljmerza there is an issue though that I don't know how to fix.
When you open the dropdown menu in a mobile view, and the button is positioned at the top of the view like that:
Screenshot-20220313230920-363x748

The menu isn't opening properly, and causing the containing card to be "stretched" like so:

Screenshot-20220313230932-356x768

@regevbr regevbr mentioned this pull request Mar 16, 2022
@ljmerza ljmerza changed the base branch from master to develop March 16, 2022 15:45
@ljmerza
Copy link
Owner

ljmerza commented Mar 16, 2022

merging to develop so i can take a look

@ljmerza ljmerza merged commit 2656877 into ljmerza:develop Mar 16, 2022
@regevbr regevbr deleted the beta branch March 16, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2022.3.X Breaks dropdown
2 participants