Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various documentation updates #157

Merged
merged 9 commits into from
Jul 25, 2018
Merged

Various documentation updates #157

merged 9 commits into from
Jul 25, 2018

Conversation

whzup
Copy link
Collaborator

@whzup whzup commented Jul 5, 2018

Created an RST file for the Inverse Kinematics tutorial and fixed some typos in the text.
Added citation in the Pyramid class.
Changed the subject line of doc strings to a commanding style.
Simplified the doc strings using the http://www.hemingwayapp.com/.

See also: #154

Created a RST file for the Inverse Kinematics tutorial and fixed some typos in the text.
@whzup
Copy link
Collaborator Author

whzup commented Jul 5, 2018

The LaTex script does not work properly as in the other RST-files, too. It may have something to do with this.

@whzup whzup added documentation Documentation improvements or fixes v0.3.0 labels Jul 6, 2018
@ljvmiranda921 ljvmiranda921 self-requested a review July 6, 2018 15:12
whzup added 3 commits July 7, 2018 09:29
Added a citation to the Pyramid topology to a paper that proposes the Delaunay triangulation as a method to obtain neighbors. http://pubs.cs.uct.ac.za/archive/00000477/01/ParticleSwarm.pdf
Changed the subject line of the docstrings to a commanding style, similar to PEP257. Fixed some typos.
Simplified some docstrings with the http://www.hemingwayapp.com/ . The minimal Readability level in important places is now "Grade 9".
@whzup whzup changed the title Add RST file for the Inverse Kinematics tutorial and fix typos Various documentation updates Jul 7, 2018
Copy link
Owner

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM except the spelling error I pointed out in one of the comments. I'll probably just squash all commits here

This uses the Delaunay method from :code:`scipy` to triangulate N-dimensional space
with simplices consisting of swarm particles [SIS2008]
This topology uses the Delaunay method from :code:`scipy`. This method is used to triangulate
N-dimensional space into simplices. The vertecies of the simplicies consist of swarm particles. [SIS2008]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vertecies to vertices 👍

Fixed a typo in the Pyramid class
@ljvmiranda921
Copy link
Owner

Reference: #129 

Added a new topology with random neighbors. Added documentation and
a test file for it and reworked the documentation of the GeneralOptimizer 
class to incorporate all available topologies. Simplified the fixture function 
for the GeneralOptimizer class. Cited the relevant paper for the 
algorithm implemented.

Updated the documentation of the Random class. 
Especially the __compute_neighbor() method. Added the comments
inside the method to the docstring and deleted irrelevant comments.
Changed the nested for-loops to one loop with the itertools library.
Added a new test for the return value of the __compute_neighbor() 
method, which checks the shape and the symmetry.
Added a new test for the return value of the __compute_neighbors() 
method, which compares the returned matrix with a preset comparison 
matrix using a seed.

Signed-off-by: Lester James V. Miranda <ljvmiranda@gmail.com>
Committed-by: @whzup
Moved the basic optimization with arguments jupyter notebook into the basic optimization jupyter notebook. Added the RST file as well.
Added notes on large boundaries and overflow errors.

See also: #152
@whzup
Copy link
Collaborator Author

whzup commented Jul 22, 2018

Since we have a lot of conflicting files, I suggest that we merge this at the very end 🙈.

@ljvmiranda921
Copy link
Owner

Yup, don’t worry!

@ljvmiranda921
Copy link
Owner

ljvmiranda921 commented Jul 23, 2018

And now we're down to this haha! Let me try this next week, might need a lot of work. The pyup bot also made a lot of PRs and some of them are failing (I wonder why, afaik it's because of a broken dependency in pyyaml), I'll merge all of them into development then to master then we'll draft the release notes by august 👍

As long as the "Resolve conflicts" button remains clickable, then that means our merge conflicts remain manageable haha

.. note::
Please keep in mind that Python has a biggest float number.
So using large boundaries in combination with exponentiation or
multiplication can lead to an :code:`OverflowError`.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this one is good. 👍

@ljvmiranda921
Copy link
Owner

ljvmiranda921 commented Jul 24, 2018

I tried resolving some merge conflicts and it passed our CI. Would you mind double-checking on your end, @whzup ? If this is all good, we can merge now and make a PR for the development branch (and v.0.3.0 preparation).

I'll be squashing all commits here into one (all about documentation etc.)

@whzup
Copy link
Collaborator Author

whzup commented Jul 24, 2018

Looking good to me 👍 Wasn't sure about the topology parametrization in the GeneralOptimizer tests because the dynamic variants are not tested. But TBH, they have the same velocity methods as the static versions so we would just run the same test twice 😄 I think we can merge it 💯

@ljvmiranda921 ljvmiranda921 merged commit c8541e3 into ljvmiranda921:development Jul 25, 2018
@whzup whzup deleted the ik_rst_file branch August 15, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvements or fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants