Added a Vagrantfile for easier collaboration #193
Conversation
There was a problem hiding this comment.
Hi @jdbohrman !
Welcome to PySwarms! Adding a Vagrantfile looks interesting, and it coincides with our aim to make the project easier to contribute/collaborate to. I'd love to have this on the project! (Although I think I still need to read up on this technology.)
Currently, we're preparing a v.0.3.0 release (#180) on August 10 and we decided to do a feature-lock (except bug-fixes, patches, and doc updates) for the next release.
We can set this feature on the v.0.4.0 pipeline (and to also buy me time to read-up on this tech).
Although there are some questions I have on-the-fly:
- There seems to be an RSA private key. Who currently owns the key? Will this affect development of other devs? Is it possible to have a project-specific key than a user-specific key?
- Some paths were hardcoded, I'll bump them in the comments below. Are they really necessary?
My guess is that we only need the Vagrantfile, provisioner.sh, and the updated README. All other files and configs inside .vagrant/ should be declared in the .gitignore.
Agian, thank you so much for this configuration and we're looking forward to working with you!
| @@ -0,0 +1 @@ | |||
| /home/jdbohrman/Documents/pyswarms | |||
There was a problem hiding this comment.
I'm wondering if the hardcoded paths are necessary.
There was a problem hiding this comment.
Hey @ljvmiranda921 great to be here! Here's the info I found on it. The documentation is slim but it appears that is the default insecure private key that Vagrant ships with. Here's a couple links:
https://www.vagrantup.com/docs/vagrantfile/ssh_settings.html
hashicorp/vagrant#8058
Also, I'm fairly sure you're absolutely correct, as running vagrant up would provision the config files and others.
| @@ -0,0 +1 @@ | |||
| {"virtualbox":{"/vagrant":{"guestpath":"/vagrant","hostpath":"/home/jdbohrman/Documents/pyswarms","disabled":false,"__vagrantfile":true}}} | |||
There was a problem hiding this comment.
I'm wondering if the hardcoded paths are necessary.
|
LGTM! Thanks for this @jdbohrman ! We appreciate your contribution, adding a Vagrantfile can indeed improve collaboration into our project. We're also looking into adding a Docker option aside from Vagrant or pure virtualenvs + I will merge this soon after we do the v.0.3.0 release on Friday. |
Hello, I've tested the build and it's passing on my system so I hope this helps with faster collaboration.