-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pypy support #381
Comments
@sobolevn Literally yesterday I thought about the same thing. |
Are there any resources about typing and |
@sobolevn I have found almost nothing about using ones together. |
Well, maybe we just have to wait. Should we close this issue? |
@sobolevn Let's will leave it opened, maybe someone can work on this issue. |
@lk-geimfari Some time ago i also tested it with pypy3. It works, but mypy module not supported by pypy bcz cpython reasons like you say here #381 (comment) 0_o |
@duckyou How we can skip dependencies selectively? I mean, how we can skip mypy only on PyPY? Is there any way to remove package from Pipfile on the fly? Something like this: - if [[ $TRAVIS_PYTHON_VERSION == "pypy3" ]]; then pipenv install --dev --skip mypy; fi UPD: We can try this: pypa/pipenv#1334 (comment) |
@lk-geimfari no, that's not possible. |
@lk-geimfari @sobolevn Yes, like says here pypa/pipenv#1334 (comment) we can filter deps: mypy = {version="*", platform_python_implementation="!='PyPy'"}
# or
mypy = {version="*", markers="platform_python_implementation != 'PyPy'"} (Other supported markers we can find here, or read PEP508 - Environment Markers) But! Heres problem... pypy3 cant work with If we want fix this issue we should filter mypy = {version="*", platform_python_implementation="!='PyPy'"}
typed-ast = {version=">=1.1.0,<1.2.0", platform_python_implementation="!='PyPy'"} If you know more canonical solution, please, share with me 😺 |
@duckyou Have you tried it? Does it work? I mean the last solution which you showed above. |
@lk-geimfari yes, its work! |
@duckyou Can you create PR, please? |
@sobolevn @lk-geimfari Appveyor don't have pypy3 enviroment 😞 Need write install script... but its so necessary tests it on travis/appveyor? PyPy3 really more faster than cpython in this situation? Maybe first benchmark it?) |
@duckyou Sure. Better to benchmark it. |
💡 For speed increasing we can implement some functions with |
@duckyou I think that at this moments this is overhead. But if we find a really slow solution we can try to optimize ones, including using |
Here are too many problems with PyPy. Let's close it and come to back to it in next year 😄. |
Please, reconsider adding |
OK, les save it for dessert 😸 |
pypy
haspython3.5
support. http://doc.pypy.org/en/latest/release-v5.10.1.htmlSo, maybe we can try to support that?
It may give our users some performance increase.
Checklist:
setup.py
classifierThe text was updated successfully, but these errors were encountered: