Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tests to pass in Windows #1518

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2024

Checklist

  • I have read contributing guidelines
  • I'm sure that I did not unrelated changes in this pull request
  • [] I have created at least one test case for the changes I have made

Related issues

Closes #1517

@lk-geimfari
Copy link
Owner

@mheguy-flo Please fix the style issues so I can merge this PR. You can fix them using scripts/format.sh.

@ghost
Copy link
Author

ghost commented Mar 22, 2024

Weird. I'll have to look into why it didn't format on save. Thanks for the heads up. :)

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #1518 (162791d) into master (c87af6d) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1518      +/-   ##
==========================================
+ Coverage   57.08%   57.13%   +0.04%     
==========================================
  Files          60       60              
  Lines        2123     2123              
==========================================
+ Hits         1212     1213       +1     
+ Misses        911      910       -1     

@lk-geimfari lk-geimfari merged commit 95a1d70 into lk-geimfari:master Mar 22, 2024
13 checks passed
@ghost ghost deleted the fix/1517 branch March 22, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests that write to files fail in windows
2 participants