Fixed #325 #332
Merged
Fixed #325 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lk-geimfari
changed the title
duckyou
reviewed
Dec 22, 2017
mimesis/helpers.py
Outdated
| :return: Random item of enum. | ||
| """ | ||
| if seed is not None: | ||
| random.seed(seed) |
There was a problem hiding this comment.
@lk-geimfari heres we have some issue. When we call this function with specific seed, it always be return same value.
>>> import random
>>> random.seed(50)
>>> random.choice([1,2,3,4,5])
4
>>> random.seed(50)
>>> random.choice([1,2,3,4,5])
4
>>> random.seed(50)
>>> random.choice([1,2,3,4,5])
4Why we cant just pass random object instance?
There was a problem hiding this comment.
@duckyou We can do it. I just thought that we can do it with a minimum of changes. Create a branch from this branch with your changes, please.
* Redesign Base providers. Now for date providers we have BaseDataProvider and super class BaseProvider * BaseSpecProvider have superclass BaseProvider * BaseProvider contains seed and random object
…into duckyou-enabled_seed_enum
…into enabled_seed_enum
* Fixed spec provider seed issues * Redesigned base providers. * Added superclass BaseProvider for BaseSpecProvider * BaseProvider contains seed and random object * Fixed generic provider for seed support
…to enabled_seed_enum
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
- Coverage 98.83% 98.65% -0.18%
==========================================
Files 58 58
Lines 1627 1634 +7
==========================================
+ Hits 1608 1612 +4
- Misses 19 22 +3 |
…to enabled_seed_enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.