Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read signature files with missing pings. #76

Merged
merged 10 commits into from
Jan 28, 2022
Merged

Read signature files with missing pings. #76

merged 10 commits into from
Jan 28, 2022

Conversation

lkilcher
Copy link
Owner

Fix for reading signature files that having missing pings

@coveralls
Copy link

coveralls commented Jan 28, 2022

Pull Request Test Coverage Report for Build 1763993653

  • 95 of 114 (83.33%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 88.942%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dolfyn/velocity.py 2 3 66.67%
dolfyn/tests/test_read_adp.py 13 16 81.25%
dolfyn/time.py 8 14 57.14%
dolfyn/io/nortek2_lib.py 54 63 85.71%
Files with Coverage Reduction New Missed Lines %
dolfyn/tests/test_read_adp.py 1 77.3%
Totals Coverage Status
Change from base Build 1763926864: -0.1%
Covered Lines: 4440
Relevant Lines: 4992

💛 - Coveralls

@lkilcher lkilcher merged commit 51f590e into master Jan 28, 2022
@jmcvey3 jmcvey3 deleted the read-sig-bug branch December 1, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants