Add ipv6 utilities

[liuyuan10]

Add ipv6 utilities to config ipv6 in LKL

Also has to pull in linux/netlink.h otherwise so many types have to be defined.

---

This change is

[thehajime]

Cool ! LGTM.

[ghost]

Review status: 0 of 6 files reviewed at latest revision, 6 unresolved discussions.

---

tools/lkl/lib/net.c, line 146 [r2] (raw file):

}

struct lkl_in6_addr {

You can use the below patch to avoid redefining the uapi structures here:

diff --git a/arch/lkl/include/uapi/asm/syscalls.h b/arch/lkl/include/uapi/asm/syscalls.h
index 813ff42..a5d24cc 100644
--- a/arch/lkl/include/uapi/asm/syscalls.h
+++ b/arch/lkl/include/uapi/asm/syscalls.h
@@ -115,6 +115,13 @@ struct sockaddr {
#include <linux/virtio_blk.h>
#include <linux/virtio_net.h>
#include <linux/virtio_ring.h>
+#define __UAPI_DEF_IN6_ADDR 1
+#include <linux/in6.h>
+#include <linux/ipv6.h>
+#include <linux/ipv6_route.h>
+#include <linux/neighbour.h>
+#include <linux/rtnetlink.h>
+

---

tools/lkl/lib/net.c, line 150 [r2] (raw file):

};

struct lkl_in6_ifreq {

No need to redefine, see my previous comment.

---

tools/lkl/lib/net.c, line 177 [r2] (raw file):

}

struct lkl_in6_rtmsg {

No need to redefine, see my previous comment.

---

tools/lkl/lib/net.c, line 223 [r2] (raw file):

}

struct lkl_ndmsg {

No need to redefine, see my previous comment.

---

tools/lkl/lib/net.c, line 233 [r2] (raw file):

};

struct lkl_rtattr {

No need to redefine, see my previous comment.

---

tools/lkl/lib/net.c, line 238 [r2] (raw file):

};

#define LKL_MSG_TRUNC 0x20

No need to redefine, see my previous comment.

---

Comments from Reviewable

[liuyuan10]

Review status: 0 of 6 files reviewed at latest revision, 6 unresolved discussions.

---

tools/lkl/lib/net.c, line 146 [r2] (raw file):

Previously, opurdila (Octavian Purdila) wrote…

You can use the below patch to avoid redefining the uapi structures here:

diff --git a/arch/lkl/include/uapi/asm/syscalls.h b/arch/lkl/include/uapi/asm/syscalls.h
index 813ff42..a5d24cc 100644
--- a/arch/lkl/include/uapi/asm/syscalls.h
+++ b/arch/lkl/include/uapi/asm/syscalls.h
@@ -115,6 +115,13 @@ struct sockaddr {
#include <linux/virtio_blk.h>
#include <linux/virtio_net.h>
#include <linux/virtio_ring.h>
+#define __UAPI_DEF_IN6_ADDR 1
+#include <linux/in6.h>
+#include <linux/ipv6.h>
+#include <linux/ipv6_route.h>
+#include <linux/neighbour.h>
+#include <linux/rtnetlink.h>
+

Don't know how to see your patch. I added all the UAPI headers I need. I still need to define LKL_MSG_TRUNC which is in linux/socket.h and seems you don't want to pull it in.

---

tools/lkl/lib/net.c, line 150 [r2] (raw file):

Previously, opurdila (Octavian Purdila) wrote…

No need to redefine, see my previous comment.

Done.

---

tools/lkl/lib/net.c, line 177 [r2] (raw file):

Previously, opurdila (Octavian Purdila) wrote…

No need to redefine, see my previous comment.

Done.

---

tools/lkl/lib/net.c, line 223 [r2] (raw file):

Previously, opurdila (Octavian Purdila) wrote…

No need to redefine, see my previous comment.

Done.

---

tools/lkl/lib/net.c, line 233 [r2] (raw file):

Previously, opurdila (Octavian Purdila) wrote…

No need to redefine, see my previous comment.

Done.

---

tools/lkl/lib/net.c, line 238 [r2] (raw file):

Previously, opurdila (Octavian Purdila) wrote…

No need to redefine, see my previous comment.

Done.

---

Comments from Reviewable

[ghost]

---

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion.

---

tools/lkl/lib/net.c, line 146 [r2] (raw file):

Previously, liuyuan10 (Yuan Liu) wrote…

Don't know how to see your patch. I added all the UAPI headers I need. I still need to define LKL_MSG_TRUNC which is in linux/socket.h and seems you don't want to pull it in.

OK, sorry about that, not sure why the patch is not properly visible. MSG_TRUNC in not defined in uapi headers so we can't pull them in. What I usually do in this case is to manually add them to arch/lkl/uapi/asm/syscalls.h see this comment:

/* Define data structures used in system calls that are not defined in UAPI

• headers */

I will merge the patch as it is, we can fix this in a subsequent patch.

---

Comments from Reviewable

[ghost]

Reviewed 3 of 6 files at r1, 1 of 1 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable