Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error label when no match found #125

Merged
merged 1 commit into from
Mar 24, 2019
Merged

Conversation

Anshuman71
Copy link
Contributor

@Anshuman71 Anshuman71 commented Mar 18, 2019

fix #112
Show/hide label accordingly
Search using 'Enter' on the keyboard
Toggle label on empty input

Show/hide label accordingly
Search using 'Enter' on keyboard
Toggle label on empty input
This was referenced Mar 18, 2019
@tarunsinghal92
Copy link
Collaborator

@Anshuman71

Testing screenshot or video please

Copy link
Collaborator

@tarunsinghal92 tarunsinghal92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing please

@Anshuman71
Copy link
Contributor Author

Anshuman71 commented Mar 20, 2019

@tarunsinghal92 thanks for the feedback. have added the screenshot for the change
asdf

screenshothinidi.png
Screenshot from 2019-03-17 17-13-3Screenshot from 2019-03-17 17-13-30 Screenshot from 2019-03-17 17-13-23 0
Screenshot from 2019-03-17 17-13-23

@llaske llaske changed the title Add error lable when no match found Add error label when no match found Mar 24, 2019
@llaske llaske merged commit bdd3321 into llaske:dev Mar 24, 2019
@llaske
Copy link
Owner

llaske commented Mar 24, 2019

Good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants