Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abacus does not display solution with big numbers #140

Closed
sahranhashim opened this issue Dec 7, 2017 · 5 comments
Closed

Abacus does not display solution with big numbers #140

sahranhashim opened this issue Dec 7, 2017 · 5 comments
Labels
enhancement
Milestone
v1.1

Comments

@sahranhashim
Copy link

The sbacus does not display the solution if the numbers get too big.
image
The solution gets cut off at the end. This problem could be resolved by displaying the solution on the side of the abacus.
@llaske llaske changed the title Abacus does not display solution Abacus does not display solution with big numbers Dec 12, 2017
@aditigupta17
Copy link

Has anyone started working on this? If not, I would like to take this up.

@llaske
Copy link
Owner

llaske commented Jan 6, 2018

Sure. Go.

@aditigupta17
Copy link

Which js file exactly in particular should I be modifying?

@llaske
Copy link
Owner

llaske commented Oct 21, 2018

Code of Abacus activity is located in directory https://github.com/llaske/sugarizer/tree/dev/activities/Abacus.activity

@FreddieN FreddieN mentioned this issue Nov 17, 2018
Merged
llaske added a commit that referenced this issue Nov 20, 2018
@llaske
Merge pull request #240 from FreddieN/dev
83b5069 
Abacus does not display solution with big numbers #140
@llaske
Copy link
Owner

llaske commented Nov 20, 2018

Fixed in #240

@llaske llaske added this to the v1.1 milestone Nov 20, 2018
@llaske llaske closed this as completed Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
3 participants
@llaske @aditigupta17 @sahranhashim