Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clicking on Abacus balls to move it #146

Closed
satyamchaudharydev opened this issue Dec 11, 2017 · 9 comments
Closed

Allow clicking on Abacus balls to move it #146

satyamchaudharydev opened this issue Dec 11, 2017 · 9 comments
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@satyamchaudharydev
Copy link

For now, we have to drag balls which is requires bit effort and is error-prone.

It would be great if we can move balls by just clicking on them and it would also be better for mobile and touch users.

@llaske llaske changed the title Abacus balls clicking Allow clicking on Abacus balls to move it Dec 12, 2017
@aditigupta17
Copy link

I am interested in working on this. Is anyone already working on it?

@llaske
Copy link
Owner

llaske commented Jan 6, 2018

Cool. Let's go.

@aditigupta17
Copy link

Which file in particular is to be modified?

@llaske
Copy link
Owner

llaske commented Jan 7, 2018

Guess it should be in https://github.com/llaske/sugarizer/blob/master/activities/Abacus.activity/js/abacusbead.js#L88
Try to debug to understand how it works.

@utkarsh-raj
Copy link
Contributor

#181 (comment)

The changes proposed by @llaske are intuitive, more than the current behaviour. I would carry the work forward by @aditigupta17 to incorporate the proposed behaviour. Any ideas for still better behaviour ? (Since the issue has been open for quite a long time)

@llaske
Copy link
Owner

llaske commented Feb 21, 2019

Like I said, we could propose an automatic move on click/tap when there is no doubt about the direction expected and let the drag gesture - since double-tap is not intuitive - when it's not possible to do the deduction. It should be tested.

@utkarsh-raj
Copy link
Contributor

#277 (comment)
I have opened a PR with some changes. Can you look and see if it feels intuitive @llaske ?

@llaske
Copy link
Owner

llaske commented Feb 23, 2019

Fixed by #146

@llaske llaske added the to be release Fixed, to be release label Feb 23, 2019
@llaske llaske added this to the v1.2 milestone Apr 10, 2019
@llaske
Copy link
Owner

llaske commented Sep 26, 2019

Closed in dd3c58d

@llaske llaske closed this as completed Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

4 participants