Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sugarizer spiral in home view #579

Closed
anshuldutt21 opened this issue Jan 26, 2020 · 11 comments
Closed

Improve Sugarizer spiral in home view #579

anshuldutt21 opened this issue Jan 26, 2020 · 11 comments
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@anshuldutt21
Copy link

I think The activity icons on the main page are a little bit packed between 2 different radiuses. They need to be seperated a little bit to give the spiral feels which can be accomplished by improving the css of the main panel. Also the journal icon must be a little above and should look different than the usual activities.
Screenshot from 2020-01-26 17-07-45

@llaske
Copy link
Owner

llaske commented Jan 26, 2020

I'm not comfortable with "Design issue" because design is not a technical problem.
BTW to answer to your suggestion: nothing is related to CSS in the Sugarizer main page. Everything is computed in JavaScript here. Feel free to send a PR if you think you could improve the current algorithm.
Regarding Journal icon appearance it comes from Sugar and it's where/how users expect to find it, it's not something we plan to change.

@Swayamsvk
Copy link

@anshuldutt21 do you want it to be a little bit spaced so that they could look more arranged and even?

@llaske
Copy link
Owner

llaske commented Feb 4, 2020

You could improve the spiral like in Sugar:

GetImage

GetImage(1)

@llaske llaske changed the title Design of Sugarizer main page Improve Sugarizer spiral in home view Feb 4, 2020
@Swayamsvk
Copy link

Working on it.

@Swayamsvk
Copy link

I have already made the necessary changes but when I open a pull request It shows older commits.
Screenshot from 2020-02-06 04-13-59

What should I do?

@sarthak-g
Copy link
Contributor

I think your branch is not updated.

@Swayamsvk
Copy link

Can you please tell me what should I do next because I have tried everything but it's not working?

@anshuldutt21
Copy link
Author

@Swayamsvk are you making a pull request on the dev branch of sugarizer?

@Swayamsvk
Copy link

Actually at first, I have made my own separate branch named dev and then made a pull request it shows the same problem and then I made a separate branch dev1 and switched to it and made a PR and it also showed the same problem. I don't know exactly about sugariser dev branch. Should I make a comparison with it or what?

@anshuldutt21
Copy link
Author

anshuldutt21 commented Feb 6, 2020 via email

@llaske
Copy link
Owner

llaske commented May 22, 2020

Fixed in e24a3d8

@llaske llaske added the to be release Fixed, to be release label May 22, 2020
@llaske llaske added this to the v1.4 milestone Sep 19, 2020
@llaske llaske closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

4 participants