Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pomodoro timer resets on break change #750

Closed
dhruvmisra opened this issue Mar 28, 2020 · 2 comments
Closed

Pomodoro timer resets on break change #750

dhruvmisra opened this issue Mar 28, 2020 · 2 comments
Labels
enhancement to be release Fixed, to be release
Milestone

Comments

@dhruvmisra
Copy link
Contributor

If the timer is paused and the break value is changed, the timer preview resets to the beginning. Although on resuming, the timer starts from the previous paused value.

pomodoroTimerIssue

The timer should follow either one of the two workflows on break change:

  1. Reset completely and start from the beginning
    OR
  2. Persist the old value when paused and resume from the same value

Please suggest the required workflow @llaske. Adding a PR to implement the second workflow however if need be, I can change it to the first one.

@llaske
Copy link
Owner

llaske commented Mar 29, 2020

Hmmm, the second workflow is probably better.

llaske added a commit that referenced this issue Apr 2, 2020
[Issue #750 fix] Fixed Pomodoro timer on break change
@llaske
Copy link
Owner

llaske commented Apr 2, 2020

Fixed in #751

@llaske llaske added the to be release Fixed, to be release label Apr 2, 2020
@llaske llaske added this to the v1.4 milestone Sep 19, 2020
@llaske llaske closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

2 participants