-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Color My World/Try version] Error between the two Korea #898
Comments
Thanks, you're right. Sound like there is a name issue in asia.geojson file: |
Fixed in #899 @Eric38fr, you could test the fix on the dev server here: https://dev.sugarizer.org |
@llaske: Okay, I have just verified in the dev.sugarizer.org instance, Asian view, and it's now okay. Other issues (should I have open a new one ? it shall be in the same file, I guess), still in the dev.sugarizer.org instance, "Color my World" module, world view, interactive mode:
I stop for the moment. Maybe others, next week-end… |
Yes please, fill a new issue for these remarks. @ccosse could you give use your opinion about these questions. |
@llaske/sugarizer <sugarizer@noreply.github.com> I will try to have a look
asap ... could be couple days until I have time, but I will follow-up.
Thanks
…On Tue, Nov 24, 2020 at 12:22 PM Lionel Laské ***@***.***> wrote:
Yes please, fill a new issue for these remarks.
@ccosse <https://github.com/ccosse> could you give use your opinion about
these questions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#898 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIBUVPKMA3SDDZHF6FKRLLSRQIXPANCNFSM4TZ6V6IQ>
.
--
ccosse.github.io
|
I fixed West Bank and Somaliland ... @Eric38fr how are you seeing French translations when those seem to be disabled now? I could add those translations but it would not matter since fr is no longer enabled. |
To see another language you need to change it in Sugarizer: go back on home view, right click on buddy icon to display menu then click on settings item then language. So choose French to see French language. |
Tried to address all things mentioned here ... N. Cyprus is clickable for me ... changed name as suggested and added any missing N. Cyprus entries throughout. Copied Palestine.png to West\ Bank.png. If you see something in double curly braces, like {{Somaliland}}, it means that the feature was present in the main geojson file but the translation of the feature name (ie country name) was not found. For images such as N Cyprus, the popup country images were made by extracting country features from a different, larger geojson file. The game, meanwhile, uses a simplified geojson file, and apparently the simple geojson differentiates between Cyprus and N. Cyprus, whereas the original used to make the pictures did not. Hence the lack of picture for N/S Cyprus. The existing image could be broken into 2 but didn't do that. |
@Eric38fr I've open a new issue here: #901 |
In the "Color my World" activity (french version of Try Sugarizer, "https://try.sugarizer.org/activities/ColorMyWorld.activity/index.html?aid=ebbbaf9a-2355-4428-93bc-bd6a7dbc651a&a=org.sugarlabs.ColorMyWorldActivity&o=87fdb363-5699-4605-a190-e289d3eb70bb&n=Activité%20ColorMyWorld"), when playing in interactive mode, if it shows the (north) Korea label and shape, I had to click of the south Korea in order to colorize it, and conversely with the Republik of Korea, which is the South Korea, to be clicked on the north one. The shapes in the transcient "guess" dialog are well associated with the corresponding names, it's just the targets to be clicked which seem to have been exchanged.
Best regards, and thanks for the tool. -- Éric
The text was updated successfully, but these errors were encountered: