Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rewrite] migrating Measure activity's localization component to i18next. #1362

Merged
merged 9 commits into from
Jun 25, 2023

Conversation

vinayaknayar
Copy link
Contributor

@vinayaknayar vinayaknayar commented May 31, 2023

This PR migrates the Measure Activity's localization component from webL10n to i18next.

Changes Made:

  • Replaced the webL10n library with i18next for localization handling.
  • Refactored the localization logic to align with i18next's patterns and best practices.
  • Updated the language resource files to i18next format.
  • Updated the component's dependencies to include i18next

Comment on lines 1 to 537
TutoOctaveSelectTitle=Choix Octave
TutoOctaveSelectContent=Cette palette montre la liste des octaves. Elle s'affiche uniquement lorsqu'aucun instrument n'est sélectionné. La fréquence correspondant à la combinaison de la note choisie et de l'octave sera affichée dans le champ de réglage de la palette suivante.
TutoShowHarmonicsTitle=Voir ou cacher harmoniques
TutoShowHarmonicsContent=Vous pouvez afficher ou masquer les harmoniques en appuyant sur ce bouton. Les lignes d'harmoniques seront affichées uniquement si un instrument est choisi et que le mode fréquence est actif. Les lignes sont de la même couleur que les notes.
TutoTuningFreqInputTitle=Saisie de la fréquence
TutoTuningFreqInputContent=Cette valeur affiche la combinaison de la note et l'octave quand aucun instrument n'est choisi. Vous pouvez aussi directement entrer la valeur de la fréquence dans le champ.
TutoTuningLineTitle=Voir ou cacher ligne de la gamme
TutoTuningLineContent=La ligne de la gamme sera affichée à la même fréquence que la valeur du champs de saisie. Vous pouvez voir ou cacher la ligne en appuyant sur ce bouton. En même temps que la ligne de la gamme, la note et l'octave correspondant à la fréquence la plus haute sera également affichée dans le coin en haut à droite de l'écran.
TutoPlayStopNoteTitle=Jouer ou arrêter note
TutoPlayStopNoteContent=Vous pouvez jouer our arrêter la note en appuyant sur ce bouton. La note jouée sera celle correspondant à la fréquence entrée dans le champ de saisie.
TutoCaptureWaveformTitle=Capture onde
TutoCaptureWaveformContent=Vous pouvez faire une capture d'écran de l'onde en appuyant sur ce bouton. La capture sera enregistrée dans le journal.

[es]
SecondsAgo=Segundos atrás
Ago={{time}} atrás
Minutes_one=minuto
Minutes_other=minutos
Hours_one=hora
Hours_other=horas
Days_one=día
Days_other=días
Weeks_one=semana
Weeks_other=semanas
Months_one=mes
Months_other=meses
Years_one=año
Years_other=años
Shutdown=Apagar
Restart=Reiniciar
MySettings=Mis ajustes
SearchHome=Buscar en hogar
JournalEmpty=Tu diario está vacío
NoMatchingActivities=No hay actividades coincidentes
ClearSearch=Limpiar búsqueda
SearchJournal=Buscar en el diario
Anytime=Cualquier momento
Today=Hoy
SinceYesterday=Desde ayer
PastWeek=La semana pasada
PastMonth=El mes pasado
PastYear=El año pasado
UserJoined={{name}} joined
UserLeft={{name}} left
A=la
B=si
C=do
D=re
E=mi
F=fa
G=sol
A♯/B♭=la♯/si♭
C♯/D♭=do♯/re♭
D♯/E♭=re♯/mi♭
F♯/G♭=fa♯/sol♭
G♯/A♭=sol♯/la♭

[pt]
SecondsAgo=Segundos atrás
Ago={{time}} atrás
Minutes_one=minuto
Minutes_other=minutos
Hours_one=hora
Hours_other=horas
Days_one=dia
Days_other=dias
Weeks_one=semana
Weeks_other=semanas
Months_one=mês
Months_other=meses
Years_one=ano
Years_other=anos
Shutdown=Desligar
Restart=Reiniciar
MySettings=Minhas Configurações
SearchHome=Pesquisar na minha página
JournalEmpty=Seu diário está vazio
NoMatchingActivities=Sem atividades correspondentes
ClearSearch=Limpar pesquisa
SearchJournal=Pesquisar no diário
Anytime=A qualquer momento
Today=Hoje
SinceYesterday=Desde ontem
PastWeek=Semana passada
PastMonth=Mês passado
PastYear=Ano passado
UserJoined={{name}} ingressou
UserLeft={{name}} saiu
A=lá
B=si
C=dó
D=ré
E=mi
F=fá
G=sol
A♯/B♭=lá♯/si♭
C♯/D♭=dó♯/ré♭
D♯/E♭=ré♯/mi♭
F♯/G♭=fá♯/sol♭
G♯/A♭=sol♯/lá♭
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you need to keep the .ini file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, i just thought it's inappropriate to delete the file. Should I remove the file?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's now useless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I will edit my last commit.

@llaske
Copy link
Owner

llaske commented Jun 17, 2023

There is some errors in the console. It seems both locale.ini and webL10n are still referenced in the activity.

image

Could you fix it?

@vinayaknayar
Copy link
Contributor Author

There is some errors in the console. It seems both locale.ini and webL10n are still referenced in the activity.

image

Could you fix it?

fixed

@llaske
Copy link
Owner

llaske commented Jun 17, 2023

Not so simple. You could remove the reference into index.html but webL10n is also referenced in Sugar Web activity.js here.
It seems it's only to start the library - instead/in addition to the start in activity - but the idea is to remove all reference to webL10n.

@vinayaknayar
Copy link
Contributor Author

Not so simple. You could remove the reference into index.html but webL10n is also referenced in Sugar Web activity.js here.
It seems it's only to start the library - instead/in addition to the start in activity - but the idea is to remove all reference to webL10n.

Ohh. So this means I need to move sugarweb to i18next too. I think I didn't notice that.

@llaske llaske merged commit 1733a44 into llaske:dev Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants