Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue #415 #457

Merged
merged 5 commits into from
Dec 5, 2019
Merged

Solved issue #415 #457

merged 5 commits into from
Dec 5, 2019

Conversation

sarthak-g
Copy link
Contributor

Added fullscreen option to XO Editor as mentioned in #415
xo1
xo2

@llaske
Copy link
Owner

llaske commented Nov 26, 2019

The toolbar is hidden/shown correctly but the window is not resized.
You must resize the window to increase the board size so you will avoid to have a white gap at the bottom of the window.

@sarthak-g
Copy link
Contributor Author

It's fine now I guess.
xoresize1
xoresize22

@llaske
Copy link
Owner

llaske commented Nov 26, 2019

It don't works. It just flash between fullscreen and unfullscreen. See below.

Peek 26-11-2019 21-38

@sarthak-g
Copy link
Contributor Author

As canvas height is changed so I've created new stage and corresponding new editor.
ezgif com-video-to-gif

@llaske
Copy link
Owner

llaske commented Nov 28, 2019

Why not just calling ResizeCanvas() method?

@sarthak-g
Copy link
Contributor Author

When calling resizeCanvas() method, it just flash between fullscreen and unfullscreen.

@llaske
Copy link
Owner

llaske commented Nov 28, 2019

The problem is that if you recreate a new stage/editor, you lost all change to colors position.
See below:

2019-11-28 17-17-03 2019-11-28 17_18_34

@sarthak-g
Copy link
Contributor Author

Yeah, I felt same.
Is there any better way you can suggest?

@llaske
Copy link
Owner

llaske commented Nov 29, 2019

Hmmm. The current implementation of resize is not ideal. Calling location.reload() is not at all a good idea 😞 BTW there is a work around to fix your current issue: call e.stop() before creating a new editor, it will force the board to be saved into the datastore so the location.reload() will not lost all dots position.
It seems to work on my side. Should be more tested thought.

@sarthak-g
Copy link
Contributor Author

Issue fixed

@llaske
Copy link
Owner

llaske commented Dec 5, 2019

Good job. Thanks.

@llaske llaske merged commit c41dd12 into llaske:dev Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants